Skip to content

Conversation

@rockenman1234
Copy link
Contributor

Hello!

I'm a Georgia Tech Student (and former OSPO Intern) - I'm very interested in this project, but I found a minor bug in the docling python notebook. The notebook appears to not properly download and install docling alongside mellea - I've added !uv pip install docling to fix the issue.

Thank you for your time! :-)

@nrfulton
Copy link
Contributor

nrfulton commented Aug 21, 2025

@rockenman1234 Thanks for catching this. We recently re-organized our dependency management and moved docling to an optional dependency group, but forgot to update the associated tutorials and examples.

Although your PR is a functional solution, the cleaner way that this is by selecting the optional docling dependency groups for installation during the mellea installation:

uv pip install mellea[docling]

Would you mind changing

    !uv pip install mellea -q
    !uv pip install docling

to

    !uv pip install mellea[docling]

in this PR, and testing that this works?

@avinash2692 or @KenOcheltree : We should do a sweep for similar issues. Do either of you have time to thoroughly review the docs and the examples for similar issues? Specifically:

  • check the rest of the ipynb's for these issues
  • check the other contents of the examples directory for similar issues (or I guess we could always assume mellea[all] for those).
  • check the narrative around commands/scripts in the tutorial to ensure that we don't have similar problems elsewhere (e.g., m tune needs [hf] I think)?

If either of you can take this up, please self-assign.

@rockenman1234
Copy link
Contributor Author

rockenman1234 commented Aug 21, 2025

@nrfulton Yes sir - all done!

My apologies - I missed that part in the ReadMe. I've updated the cell - and confirmed it also fixed the issue!

If you'd like, I can help out more by scanning & fixing more of the ipynb's for y'all.

Thank you again!

@nrfulton
Copy link
Contributor

If you'd like, I can help out more by scanning & fixing more of the ipynb's for y'all.

We'll never say no to extra help! If you have the spare cycles, please go ahead :) I'll merge this PR now and let you open a new one with additional fixes.

@nrfulton nrfulton merged commit d1bb427 into generative-computing:main Aug 21, 2025
3 checks passed
@rockenman1234
Copy link
Contributor Author

@nrfulton I'm always happy to help! 😃

It's not a problem at all - thank you for your time, I should be able to verify the notebooks before the weekend. This helps me out since I wanted to incorporate Mellea into my own Root Cause Analysis tool (already using Granite, BeeAI, and Docling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants