feat: add prometheus breaker_state metric#20
Merged
cadgerfeast merged 3 commits intomainfrom Apr 8, 2025
Merged
Conversation
tichon29
approved these changes
Apr 7, 2025
Collaborator
tichon29
left a comment
tichon29
left a comment
There was a problem hiding this comment.
Everything looks good to me.
Regarding my comment about Reset always returning 0, we could keep the return value to be coherent with what has been done for the inc method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one fixes #19 and adds a few metrics for circuit breakers, hopefully fixing #18.
Prometheus metrics added in this PR:
breaker_state: Works as an enum, it's actually three counters with a specific state label that can beclosed | half-opened | opened, and is equal to1if active, or0otherwise.failure_rate: A Gauge that is a percentage or current failures in the circuit.slow_rate: A Gauge that is a percentage or current slow requests in the circuit.