Update transport options and add StreamableHTTPConfig#198
Update transport options and add StreamableHTTPConfig#198kevensen wants to merge 2 commits intogenkit-ai:mainfrom
Conversation
Added Streamable HTTP as a transport option and defined StreamableHTTPConfig.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @kevensen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Model Context Protocol (MCP) by integrating Streamable HTTP as a new transport option. The changes include updating the relevant documentation to list Streamable HTTP alongside existing options, providing a practical configuration example, and formally defining the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Model Context Protocol documentation to add StreamableHTTP as a transport option. The changes are a good addition, but I have one suggestion to fix a missing heading in the markdown. I also noticed that the MCPClientOptions struct definition was not updated to include the new StreamableHTTP field, which makes the documentation inconsistent. Since this is outside the changed lines, I couldn't add a specific comment, but it would be beneficial to include this update.
|
/gcbrun |
Added Streamable HTTP as a transport option and defined StreamableHTTPConfig.