Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
shepardxia
reviewed
Feb 6, 2026
Contributor
shepardxia
left a comment
shepardxia
left a comment
There was a problem hiding this comment.
Format is a bit weird, are you using pre-commit hooks? Might be worth checking the codecov too. But otherwise backend itself looks good to me!
genlm/backend/llm/vllm.py
Outdated
Comment on lines
11
to
12
| os.environ.setdefault("VLLM_USE_V1", "1") | ||
| os.environ.setdefault("VLLM_ENABLE_V1_MULTIPROCESSING", "0") |
Contributor
There was a problem hiding this comment.
cleaner to move this inside the try block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to vLLM v1