Skip to content

Add spec suite gate to PR CI#209

Merged
imaurer merged 1 commit intomainfrom
add-spec-suite-ci-gate
Mar 13, 2026
Merged

Add spec suite gate to PR CI#209
imaurer merged 1 commit intomainfrom
add-spec-suite-ci-gate

Conversation

@imaurer
Copy link
Collaborator

@imaurer imaurer commented Mar 13, 2026

Summary

  • Adds a new spec job to .github/workflows/ci.yml that builds target/release/biomcp via cargo build --release --locked and then runs make spec
  • Removes the stale statement in analysis/technical/overview.md that said no GitHub workflow runs make spec; updates the doc to describe the five-job PR CI surface
  • Extends tests/test_upstream_planning_analysis_docs.py with assertions that guard the five-job CI inventory and the exact spec job run steps, so CI docs and workflow stay in sync

Why

The BioMCP spec suite is the repo's executable CLI contract documentation, but no PR CI job ran it. A failing spec could go undetected until a manual local run. This change closes that gap so spec regressions fail in CI before review.

Notes

  • The Makefile already prepends target/release to PATH so make spec uses the freshly built binary rather than the potentially stale editable .venv/bin/biomcp install
  • Tests gated on OPENFDA_API_KEY are skipped in CI via spec/conftest.py — no secrets required in the new job

@imaurer imaurer merged commit 6a205e7 into main Mar 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant