Fix retraction filter bypass and leading-NOT eligibility parsing#212
Merged
Fix retraction filter bypass and leading-NOT eligibility parsing#212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_retractedwas hardcoded tofalseinfrom_pubtator_search_result, so--exclude-retractedsilently passed retracted articles from the PubTator leg. Changed toOption<bool>withNonefor PubTator rows;unwrap_or(true)conservatively excludes unknowns. Duplicate PMID merge now propagates retraction status from Europe PMC when a PubTator-first row is deduplicated.essie_escape_boolean_expressionskippedoperators[0]when emitting, so inputs likeNOT MSI-HbecameMSI-H, inverting user intent. Fixed to detect and emit the leading unary operator before the first term.Both fixes include new unit tests. All existing tests continue to pass.
Test plan
cargo test retract— 6 retraction-related tests passcargo test essie_escape— 3 boolean expression tests pass (including leading-NOT and AND-NOT cases)cargo test— all tests passmake spec— spec suite passes