fix(run): cross-platform browser opening and secure token input#545
Open
waklo wants to merge 1 commit intogensyn-ai:mainfrom
Open
fix(run): cross-platform browser opening and secure token input#545waklo wants to merge 1 commit intogensyn-ai:mainfrom
waklo wants to merge 1 commit intogensyn-ai:mainfrom
Conversation
Use xdg-open on Linux and open on macOS to launch http://localhost:3000, improving cross-platform UX. Switch HF token prompt to read -s to avoid echoing the token to the terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the
run_rl_swarm.shUX and startup reliability across platforms.Motivation
opento launch http://localhost:3000, which only exists on macOS. On Linux this fails and the user has to open the URL manually.Changes
xdg-open(Linux) andopen(macOS) and use whichever is available to launch http://localhost:3000. If neither is available, fall back to the existing manual message.read -sso the token is not echoed to the terminal, adding a newline afterwards for a clean prompt.Testing
run_rl_swarm.shon:openwhen available.xdg-openwhen available.