Documentation: lib.sh: Support slot scope in get_main_tree_keyword() #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionenwks
approved these changes
Jan 7, 2024
Contributor
ionenwks
left a comment
ionenwks
left a comment
There was a problem hiding this comment.
Not familiar with these scripts but I don't see anything that stands out as bad in the changes from a quick look.
thesamesam
approved these changes
Jan 10, 2024
Member
Author
|
Needs more work for the case of no ebuild in main tree available. |
In general, use more portageq instead of sed, grep, ls, sort and tail. Signed-off-by: Andreas Sturmlechner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, use more portageq instead of sed, grep, ls, sort and tail.