PB-2241: implement new version of BABS signatures#101
Conversation
Added new BABS signatures Optimized handling of special characters and umlauts in sv2png.py and generate_babs_dict Added short section in README.md on requirements for filenames of new signatures Clearer implementation of the dryrun logic in the svg2png.py script
…icate functions from scripts
pakb
left a comment
There was a problem hiding this comment.
Is there really a need for 3 separate dictionary files? They all contains all translation in the 3 languages.
Yes. Otherwise we'd have to change the service's logic and also the one in the frontend. |
I think we can safely write down in the future specs that we need to have a per-lang icon URL approach for each "icon", instead of what we currently have. |
rebert
left a comment
There was a problem hiding this comment.
lgtm beside the remark with the 🪤
Added new BABS signatures
Optimized handling of special characters and umlauts in sv2png.py and generate_babs_dict Added short section in README.md on requirements for filenames of new signatures Clearer implementation of the dryrun logic in the svg2png.py script