Skip to content

PB-2241: implement new version of BABS signatures#101

Merged
hansmannj merged 4 commits intodevelopfrom
feat_PB-2241_new_babs_signatures
Mar 19, 2026
Merged

PB-2241: implement new version of BABS signatures#101
hansmannj merged 4 commits intodevelopfrom
feat_PB-2241_new_babs_signatures

Conversation

@hansmannj
Copy link
Member

@hansmannj hansmannj commented Mar 9, 2026

Added new BABS signatures
Optimized handling of special characters and umlauts in sv2png.py and generate_babs_dict Added short section in README.md on requirements for filenames of new signatures Clearer implementation of the dryrun logic in the svg2png.py script

  • TODO: Remember to unlist the old versions when deploying

Added new BABS signatures
Optimized handling of special characters and umlauts in sv2png.py and generate_babs_dict
Added short section in README.md on requirements for filenames of new signatures
Clearer implementation of the dryrun logic in the svg2png.py script
@hansmannj hansmannj requested review from pakb and rebert March 9, 2026 13:35
@hansmannj hansmannj marked this pull request as draft March 9, 2026 13:39
@hansmannj hansmannj marked this pull request as ready for review March 9, 2026 14:32
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there really a need for 3 separate dictionary files? They all contains all translation in the 3 languages.

@hansmannj
Copy link
Member Author

hansmannj commented Mar 9, 2026

Is there really a need for 3 separate dictionary files? They all contains all translation in the 3 languages.

Yes. Otherwise we'd have to change the service's logic and also the one in the frontend.
Probably can optimize things in SWISSGEO context, but not here and now.
It is the same way already with the v2 ones.
Also, the mouseover texts are in all 3 languages for each icon inside the dictionary, right.
But the filename is contained only once - in the language of the dictionary.

@pakb
Copy link
Contributor

pakb commented Mar 9, 2026

Probably can optimize things in SWISSGEO context

I think we can safely write down in the future specs that we need to have a per-lang icon URL approach for each "icon", instead of what we currently have.

@hansmannj hansmannj requested a review from pakb March 18, 2026 09:04
Copy link
Contributor

@rebert rebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm beside the remark with the 🪤

@hansmannj hansmannj merged commit 99368b3 into develop Mar 19, 2026
3 checks passed
@hansmannj hansmannj deleted the feat_PB-2241_new_babs_signatures branch March 19, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants