Enable strict null checks (#80)

* Enable strict null checks

* Fix type errors

Author: kylebarron

src/arc-layer.ts

@@ -96,6 +96,7 @@ const ourDefaultProps = {
   _validate: true,
 };
 
+// @ts-expect-error Type error in merging default props with ours
 const defaultProps: DefaultProps<GeoArrowArcLayerProps> = {
   ..._defaultProps,
   ...ourDefaultProps,

src/column-layer.ts

@@ -89,6 +89,7 @@ const ourDefaultProps = {
   _validate: true,
 };
 
+// @ts-expect-error Type error in merging default props with ours
 const defaultProps: DefaultProps<GeoArrowColumnLayerProps> = {
   ..._defaultProps,
   ...ourDefaultProps,

src/constants.ts

@@ -9,3 +9,5 @@ export enum EXTENSION_NAME {
   MULTILINESTRING = "geoarrow.multilinestring",
   MULTIPOLYGON = "geoarrow.multipolygon",
 }
+
+export const DEFAULT_COLOR: [number, number, number, number] = [0, 0, 0, 255];

src/heatmap-layer.ts

@@ -64,6 +64,7 @@ const ourDefaultProps = {
   _validate: true,
 };
 
+// @ts-expect-error Type error in merging default props with ours
 const defaultProps: DefaultProps<GeoArrowHeatmapLayerProps> = {
   ..._defaultProps,
   ...ourDefaultProps,

src/scatterplot-layer.ts

@@ -79,6 +79,7 @@ const ourDefaultProps = {
   _validate: true,
 };
 
+// @ts-expect-error Type error in merging default props with ours
 const defaultProps: DefaultProps<GeoArrowScatterplotLayerProps> = {
   ..._upstreamDefaultProps,
   ...ourDefaultProps,

src/solid-polygon-layer.ts

@@ -21,7 +21,7 @@ import {
 } from "./utils.js";
 import { getPickingInfo } from "./picking.js";
 import { ColorAccessor, FloatAccessor, GeoArrowPickingInfo } from "./types.js";
-import { EXTENSION_NAME } from "./constants.js";
+import { DEFAULT_COLOR, EXTENSION_NAME } from "./constants.js";
 import { validateAccessors } from "./validate.js";
 
 /** All properties supported by GeoArrowSolidPolygonLayer */
@@ -80,6 +80,7 @@ const ourDefaultProps: Pick<
   _validate: true,
 };
 
+// @ts-expect-error Type error in merging default props with ours
 const defaultProps: DefaultProps<GeoArrowSolidPolygonLayerProps> = {
   ..._defaultProps,
   ...ourDefaultProps,
@@ -312,7 +313,7 @@ function encodePickingColors(
   const largestOffset = geomToCoordOffsets[geomToCoordOffsets.length - 1];
   const pickingColors = new Uint8ClampedArray(largestOffset);
 
-  const pickingColor = [];
+  const pickingColor: number[] = [];
   for (let arrayIdx = 0; arrayIdx < geomToCoordOffsets.length - 1; arrayIdx++) {
     const thisOffset = geomToCoordOffsets[arrayIdx];
     const nextOffset = geomToCoordOffsets[arrayIdx + 1];

src/utils.ts

@@ -96,7 +96,7 @@ function convertStructToFixedSizeList(
 
 type AssignAccessorProps = {
   /** The object on which to assign the resolved accesor */
-  props: object;
+  props: Record<string, any>;
   /** The name of the prop to set */
   propName: string;
   /** The user-supplied input to the layer. Must either be a scalar value or a reference to a column in the table. */
@@ -136,7 +136,6 @@ export function assignAccessor(args: AssignAccessorProps) {
         );
       }
 
-      // @ts-expect-error Property 'data' does not exist on type 'object'.
       props.data.attributes[propName] = {
         value: values,
         size: columnData.type.listSize,
@@ -152,7 +151,6 @@ export function assignAccessor(args: AssignAccessorProps) {
         values = expandArrayToCoords(values, 1, geomCoordOffsets);
       }
 
-      // @ts-expect-error Property 'data' does not exist on type 'object'.
       props.data.attributes[propName] = {
         value: values,
         size: 1,
@@ -316,8 +314,8 @@ export function extractAccessorsFromProps(
   props: Record<string, any>,
   excludeKeys: string[],
 ): [Record<string, any>, Record<string, any>] {
-  const accessors = {};
-  const otherProps = {};
+  const accessors: Record<string, any> = {};
+  const otherProps: Record<string, any> = {};
   for (const [key, value] of Object.entries(props)) {
     if (excludeKeys.includes(key)) {
       continue;

src/validate.ts

@@ -1,6 +1,5 @@
 import { assert } from "@deck.gl/core/typed";
 import * as arrow from "apache-arrow";
-import * as ga from "@geoarrow/geoarrow-js";
 
 export function validateAccessors(
   props: Record<string, any>,

tsconfig.json

@@ -10,9 +10,9 @@
     "forceConsistentCasingInFileNames": true,
     "skipLibCheck": true,
     "noEmitOnError": false,
-    "outDir": "dist"
-    // "strict": true,
-    // "strictNullChecks": true,
+    "outDir": "dist",
+    "strict": true,
+    "strictNullChecks": true
     // "lib": [
     //   "es2019.array", "es6", "dom"
     // ]