Skip to content

Fixed std::vector calls on a gd::vector #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cvolton merged 1 commit into from
Feb 27, 2026
+2 −4
Merged

Fixed std::vector calls on a gd::vector #1874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions loader/include/Geode/cocos/extensions/network/HttpRequest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,7 @@ class CC_DLL CCHttpRequest : public CCObject
*/
inline void setRequestData(const char* buffer, unsigned int len)
{
auto vec = std::vector<char>(_requestData);
vec.assign(buffer, buffer + len);
_requestData = gd::vector<char>(vec);
_requestData.assign(buffer, buffer + len);
};
/** Get the request data pointer back */
inline char* getRequestData()
Expand All @@ -132,7 +130,7 @@ class CC_DLL CCHttpRequest : public CCObject
/** Get the size of request data back */
inline int getRequestDataSize()
{
return std::vector<char>(_requestData).size();
return _requestData.size();
}

/** Option field. You can set a string tag to identify your request, this tag can be found in HttpResponse->getHttpRequest->getTag()
Expand Down
Loading