Implement an interface that external surface deformation tools can use.#6584
Open
bangerth wants to merge 6 commits intogeodynamics:mainfrom
Open
Implement an interface that external surface deformation tools can use.#6584bangerth wants to merge 6 commits intogeodynamics:mainfrom
bangerth wants to merge 6 commits intogeodynamics:mainfrom
Conversation
Contributor
|
This sounds great! Just to clarify, does this mean it will allow interpolation of values at remote points, for example on a higher-resolution mesh used by an external surface model? Im looking forward ! |
Contributor
Author
|
@Minerallo Yes, exactly. You won't have to do the interpolation yourself any more, just say "I need the solution at these points" and it will be given to you :-) |
|
For run-control and data-query functions, consider looking to the Basic Model Interface (BMI) for inspiration. For example, BMI run-control specifications in C++ look like: and variable getters and setters look like: |
Contributor
Author
|
@tjhei 's current draft of an implementation: landlab-aspect#9 @danieldouglas92 FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tjhei and @gregtucker and I were brainstorming how the interface to external tools for surface deformation should look like. I promised @tjhei a prototype that he could fill in with the
MPIRemotePointEvaluationtools he has been writing.@tjhei Feel free to push to this branch. I think I marked up all the places where you have to put code.
@xlia62, @Minerallo, @Djneu, @MFraters Once this is finished, it may actually be of interest to you as well. Feedback on the interface, documentation, and implementation of the class here is certainly welcome!