Let SimulatorAccess store an observer pointer to Simulator.#6870
Open
bangerth wants to merge 1 commit intogeodynamics:mainfrom
Open
Let SimulatorAccess store an observer pointer to Simulator.#6870bangerth wants to merge 1 commit intogeodynamics:mainfrom
bangerth wants to merge 1 commit intogeodynamics:mainfrom
Conversation
gassmoeller
reviewed
Feb 24, 2026
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
Looks like there is a header missing for deal.II 9.6. I dont really understand the errors for 9.7. Something in the particle property manager?
| #include <aspect/particle/manager.h> | ||
|
|
||
| #include <aspect/utilities.h> | ||
| #include <aspect/simulator.h> |
Contributor
Author
There was a problem hiding this comment.
See above:
...with the exception of one place that creates a plugin and where apparently one now needs to know the declaration of class Simulator to check a static assertion in class ObserverPointer (namely: Is Simulator really derived from EnableObserverPointer?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, it stores a bare pointer. This is easily changed with the exception of one place that creates a plugin and where apparently one now needs to know the declaration of
class Simulatorto check a static assertion inclass ObserverPointer(namely: IsSimulatorreally derived fromEnableObserverPointer?).This isn't going to solve the memory issue we talked about in the call today, but it's still worthwhile replacing bare pointers by smarter classes that help us track memory stuff. Let's see if anything breaks with this patch.