Prescribed solution initial temperature

[lhy11009]

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

A new "temperature from initial" in the prescribed condition plugin system that uses an indicator function and reads the initial condition in the indicated region.

Before your first pull request:

• I have read the guidelines in our CONTRIBUTING.md document.

For all pull requests:

• I have followed the instructions for indenting my code.

For new features/models or changes of existing features:

• I have tested my new feature locally to ensure it is correct.
• I have created a testcase for the new feature/benchmark in the tests/ directory.
• I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

[lhy11009]

In the test I included, adiabatic initial temperature condition with a huge thermal conductivity (1e22), the temperature will quickly cool down at time = 1s. Then, I prescribe a region in the lower-middle part of the domain by the indicator function and maintain the initial temperature.

time = 0

time = 1s

[alarshi]

Nice! Thank you for making this contribution. I have minor comments, otherwise it looks good to me.

[lhy11009]

@alarshi Thanks for reviewing my PR. I think I have addressed all the conversations. And I did add 3 lines between the functions.

[alarshi]

Thank you! Besides one comment, it looks good to me. I am not sure why the documentation tester is failing though.

[gassmoeller]

I agree with all the point mentioned by Arushi and just have minor additional comments.

About the tester: See my comment here, we now require to also update the parameter documentation when you introduce new parameters. See there for a description of how to fix this. Maybe we should include this as a command when running make indent, or maybe we can create a make update_parameters command.

[lhy11009]

I agree with all the point mentioned by Arushi and just have minor additional comments.

About the tester: See my comment here, we now require to also update the parameter documentation when you introduce new parameters. See there for a description of how to fix this. Maybe we should include this as a command when running make indent, or maybe we can create a make update_parameters command.

I actually run the script under doc, but it looks confusing in the command line, and I am not sure if this takes effect. Apparently, my executable is there, but it keeps saying "Please provide the absolute path of the ASPECT executable as the first argument to this script or create a link in the main source directory."

[lochy@lochy-shilofue1 doc]$ ls ../build/aspect
../build/aspect
[lochy@lochy-shilofue1 doc]$ ./update_parameters.sh ../build/aspect
~/Softwares/aspect/doc ~/Softwares/aspect/doc
Please provide the absolute path of the ASPECT executable as the first argument to this script or create a link in the main source directory.
[lochy@lochy-shilofue1 doc]$ ./update_parameters.sh ../build/aspect-debug
~/Softwares/aspect/doc ~/Softwares/aspect/doc
Please provide the absolute path of the ASPECT executable as the first argument to this script or create a link in the main source directory.
[lochy@lochy-shilofue1 doc]$ ./update_parameters.sh ../build/aspect-release
~/Softwares/aspect/doc ~/Softwares/aspect/doc
Please provide the absolute path of the ASPECT executable as the first argument to this script or create a link in the main source directory.

[gassmoeller]

you need to provide the 'absolute' path, but you are currently providing a 'relative' path (relative to your current directory). An absolute path starts with /, e.g. /home/haoyuan/aspect/build/aspect would be an absolute path. You can also use ~ as a shortcut for 'my home directory'. E.g. my path would look like this: ~/software/aspect/build/aspect.

[lhy11009]

Okay, yes, I see. I missed that it was the absolute path. I think I did it right this time.

[lhy11009]

But there is still some bug in the documentation and parameters ...

[lhy11009]

Here is what I saw when running the update_parameters script. And my branch should be up-to-date.

[lochy@lochy-shilofue1 doc]$ ./update_parameters.sh /home/lochy/Softwares/aspect/build/aspect-release
~/Softwares/aspect/doc ~/Softwares/aspect/doc
Creating parameters.json
Convert parameters to markdown files
--- Found astyle 2.04 at /home/lochy/Softwares/astyle/build/gcc/bin/astyle
--- Indenting all ASPECT header and source files
~/Softwares/aspect/doc
done

[alarshi]

@lhy11009 : Could you update your main and rebase this branch? It looks like you are getting the error because #6884 got merged in the meantime. Thank you!

[lhy11009]

@lhy11009 : Could you update your main and rebase this branch? It looks like you are getting the error because #6884 got merged in the meantime. Thank you!

Sure thing. I just did that.

[gassmoeller]

Looks all good now. The failing tester is unrelated and was fixed in deal.II already. Let's merge this.