Prescribed condition from initial composition#6889
Prescribed condition from initial composition#6889lhy11009 wants to merge 1 commit intogeodynamics:mainfrom
Conversation
|
Currently, this works for the field methods, and I don't think it works for the particle method. In the test I included, I modified from the composition_passive.prm and prescribed the composition on the left half of the domain. So the left side would stay the same value while the right side is advecting. |
|
Ideally, I would want a method that works for the particle method. At least that's something I was thinking when creating the PR. However, I feel this is also useful with the field method. |
danieldouglas92
left a comment
There was a problem hiding this comment.
This is great @lhy11009 thanks for this! I only had a few minor comments about cleaning up the test file and the formatting of things, but other then that I think looks great.
bf0ec1e to
23b9afd
Compare
|
Hi @danieldouglas92, Thanks for reviewing my changes. |
|
@lhy11009 the rest of your changes look great! Thanks for addressing them so quickly. If including the cookbook parameter file also causes the model to hang don't worry about it, but I would try adding the include statement to that cookbook file if you haven't already and see what happens. |
gassmoeller
left a comment
There was a problem hiding this comment.
The code looks all good @lhy11009, and thanks for the reviews @danieldouglas92. I have some minor comments and questions, but the functionality looks all good.
55fc501 to
ad64145
Compare
ad64145 to
4885ae9
Compare


Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
Prescribe the composition field from the initial composition fields.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: