Skip to content

minor manual clarification#6906

Merged
gassmoeller merged 3 commits intogeodynamics:mainfrom
maxrudolph:manual_clarification
Mar 20, 2026
Merged

minor manual clarification#6906
gassmoeller merged 3 commits intogeodynamics:mainfrom
maxrudolph:manual_clarification

Conversation

@maxrudolph
Copy link
Contributor

@maxrudolph maxrudolph commented Mar 19, 2026

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Since #6881 we check in our testers for updated parameters and request to update the parameter documentation if something changes. Could you go to the doc/ directory and run ./update_parameters.sh $HOME/path_to_your_aspect/aspect to update the parameter documentation? This will be simpler in the future when #6907 is merged, then you can run make parameters to do both the indenting and the parameter documentation update.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, something went wrong during the process, the update parameters script also updated other parameters as well. Did you maybe start it with an ASPECT that was compiled on a different branch?

It seems I need to improve the process a bit, I will include that in #6907. For now I just reran the parameter script and updated your PR here. This should be ready to merge when the testers are done.

@gassmoeller gassmoeller merged commit 26b19aa into geodynamics:main Mar 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants