Equilibrate relaxed composite#710
Merged
bobmyhill merged 6 commits intogeodynamics:mainfrom Dec 5, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies
burnman.equilibrateso that it can equilibrate RelaxedComposite objects. Internally, the equilibrate function extracts the unrelaxed composite object from theunrelaxedattribute of the RelaxedComposite, conducts the equilibration on that object, and then copies the state (pressure, temperature, molar_fractions, number_of_moles) from the unrelaxed object back onto the relaxed composite.A new test is introduced which fails with the current main branch.
Other minor related changes:
Materialto setnumber_of_molesonly if it hasn't already been set, preventing accidental overwrites in derived classes.reset()method is now called innumber_of_moles, ensuring that extensive material properties are output correctly immediately after changing number_of_moles.copy_state_from_unrelaxed()function toRelaxedCompositeto facilitate the changes toequilibrate.