Skip to content

Refresh minimal-embeds cache when "Refresh embed cache" action is called #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoff-maddock merged 3 commits into from
Dec 1, 2025
Merged

Refresh minimal-embeds cache when "Refresh embed cache" action is called #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f0c1c1
Initial plan
Copilot Nov 27, 2025
a18bc49
Refresh minimal-embeds cache along with standard embeds cache
Copilot Nov 27, 2025
b926935
Add consistent fallback handling for embeds data
Copilot Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/EntityDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,16 +165,22 @@ export default function EntityDetail({ entitySlug, initialEntity }: { entitySlug
setEmbedsLoading(true);

try {
// Clear the old cache first
// Clear the old cache first (both standard and minimal embeds)
clearEmbedCache('entities', entity.slug, 'embeds');
clearEmbedCache('entities', entity.slug, 'minimal-embeds');

// Fetch fresh embeds from API
const response = await api.get<{ data: string[] }>(`/entities/${entity.slug}/embeds`);
const embedsData = response.data.data;
const embedsData = response.data.data || [];

// Store in localStorage
setEmbedCache('entities', entity.slug, embedsData, 'embeds');

// Fetch and cache minimal embeds as well
const minimalResponse = await api.get<{ data: string[] }>(`/entities/${entity.slug}/minimal-embeds`);
const minimalEmbedsData = minimalResponse.data.data || [];
setEmbedCache('entities', entity.slug, minimalEmbedsData, 'minimal-embeds');

// Update display
setEmbeds(embedsData);
setEmbedsError(null);
Expand Down
12 changes: 9 additions & 3 deletions src/components/EventDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,16 +177,22 @@ export default function EventDetail({ slug, initialEvent }: { slug: string; init
setActionsMenuOpen(false);

try {
// Clear the old cache first
// Clear the old cache first (both standard and minimal embeds)
clearEmbedCache('events', event.slug, 'embeds');
clearEmbedCache('events', event.slug, 'minimal-embeds');

// Fetch fresh embeds from API
// Fetch fresh embeds from API (standard embeds)
const { data } = await api.get<{ data: string[] }>(`/events/${event.slug}/embeds`);
const embedsData = data.data;
const embedsData = data.data || [];

// Store in localStorage
setEmbedCache('events', event.slug, embedsData, 'embeds');

// Fetch and cache minimal embeds as well
const { data: minimalData } = await api.get<{ data: string[] }>(`/events/${event.slug}/minimal-embeds`);
const minimalEmbedsData = minimalData.data || [];
setEmbedCache('events', event.slug, minimalEmbedsData, 'minimal-embeds');

// Refetch to display the new data
await refetchEmbeds();

Expand Down