[WIP] Add GeoJSON plugin to view files in GIS viewer#725
[WIP] Add GeoJSON plugin to view files in GIS viewer#725kaushiksrini wants to merge 3 commits intogeojupyter:mainfrom
Conversation
|
|
|
Integration tests report: appsharing.space |
arjxn-py
left a comment
arjxn-py
left a comment
There was a problem hiding this comment.
Thank you for starting this @kaushiksrini, great progress already.
I have given a preliminary review to give you some context of what you might be missing. I hope it helps, don't hesitate to follow up with questions in cas you would have.
| @@ -0,0 +1,89 @@ | |||
| import { | |||
There was a problem hiding this comment.
I looks like you followed how we initialize model for stl/step files on JupyterCAD, but in the case of JupyterGIS, the model properties are fairly different, most importantly layers & sources instead of objects, for context https://github.com/geojupyter/jupytergis/blob/main/packages/schema/src/doc.ts
| return this._objectChanged; | ||
| } | ||
|
|
||
| get objects(): Array<any> { |
There was a problem hiding this comment.
This should be get layers() and it should respect vectorlayer schema - https://github.com/geojupyter/jupytergis/blob/main/packages/schema/src/schema/project/layers/vectorlayer.json
Similarly there should be getters for sources & layerTree too and the sources getter shall respect https://github.com/geojupyter/jupytergis/blob/main/packages/schema/src/schema/geojsonsource.json - note that you can either give it the parameter path or directly write the content of geojson in data
2 participants
Description
Note: Still a work in progress. I am not able to get the geojson to render in the viewer - any ideas on what I am missing?
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--725.org.readthedocs.build/en/725/
💡 JupyterLite preview: https://jupytergis--725.org.readthedocs.build/en/725/lite