Support jupyter-collaboration 4.x #848
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mfisher87
force-pushed
the
remove-collab-upper-bound
branch
from
e0e03bb to
e125c41
Compare
|
Integration tests report: appsharing.space |
|
I'm a bit frustrated trying to make this work :( jupyter-collaboration seems to have undocumented breaking changes and I need more context to make this change. @davidbrochart can you provide some guidance? |
mfisher87
changed the title
|
Hmm... we should have made a better effort documenting that transition, sorry about this. For the most part you should be able to swap - import { ICollaborativeDrive } from '@jupyter/collaborative-drive';
+ import { ICollaborativeContentProvider } from '@jupyter/collaborative-drive'; |
|
👋 hi @krassowski , thanks! Will give that a shot :) |
mfisher87
force-pushed
the
remove-collab-upper-bound
branch
from
e125c41 to
e4f8565
Compare
v3.x includes a bug preventing disable of autosave. Upgrading to v4.1.0 is recommended. I'm not sure if we should bump our lower bound as well, but this change will un-restrict people from using 4.x releases with JGIS.
mfisher87
force-pushed
the
remove-collab-upper-bound
branch
from
e4f8565 to
fdcd76b
Compare
Switch from ICollaborativeDrive to ICollaborativeContentProvider at advice of Michał Krassowski: <geojupyter#848 (comment)>
|
|
|
That seems to have gotten us past that error, but now: 🤔 |
I don't know why I'm making this change, I just cribbed it from here: <jupyterlab/jupyter-chat@2b688d7#diff-8fc8f31371b7227cd359debf0e0c3a1c7da5718d36d541185c4f9e029be9ef3b>
|
OK got the build passing but it was by cribbing code from other projects 😆 I have no idea why or if it's right. Working on testing now... |
|
Hm... now we have no file browser tab 😆 |
Hmm the implementation actually does have a That said, I believe that your current implementation (using contents manager) should work fine. |
|
Thanks @krassowski ! where I'm at now is the build passes, but JupyterLab has no file browser, plus collaborative functionality (in a Notebook) isn't working. I'm getting lots of errors in my console, and I'm not sure yet where to go next! Any hints would be deeply appreciated :) |
|
Do you have jupyter-collaboration in latest version installed? These logs look as if something went wrong with compilation/bundling, maybe stale files somewhere? I would try uninstalling, clearing all extension files and reinstalling. The integration tests do not show such issue, right? |
|
Great call Michał. Thanks! It was some sort of local state issue. I blew away the whole environment and started from scratch. jupyter-collaboration is at 4.1.1, the file browser works again, and collaboration in the notebook works again. But collaboration in jupytergis projects does not work. Taking a peek at the test failures ... |
mfisher87
force-pushed
the
remove-collab-upper-bound
branch
from
99945a8 to
239f9c8
Compare
|
One issue is that the JupyterLite build is not detecting the collaborative drive. Perhaps an issue with how we're using https://github.com/QuantStack/my-jupyter-shared-drive ? |
Probably that my-jupyter-drive needs to be updated for jupyter-collaboration 4? Friendly ping @davidbrochart |
|
It has been updated to use the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #846
Description
v3.x includes a bug preventing disable of autosave. Upgrading to v4.1.0 is recommended. There seem to be non-trivial breaking changes so I don't think we should try to support 3.x and 4.x.
This will also enable use of the new share UI in JupyterHub. We're currently setting up a geojupyter hub with 2i2c and that functionality is important.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint