-
Notifications
You must be signed in to change notification settings - Fork 57
Fix geotif file loading #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f97c0b4
to
ddd4fcb
Compare
Integration tests report: appsharing.space |
Seems it's to be expected. It loads really slowly but that's a different issue I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use an architecture documentation page for this! LGTM and seems to work fine!
Perhaps the slowness is because this GeoTIFF file only has two levels of overviews.
Check release failure is resolved by #888 !
Hey @gjmooney I think part of the performance problem is we used to cache the file's metadata in indexeddb, but we no longer do as of this change: gjmooney@89fd8fb#diff-f155b38648f9ab1ea37e6115e82cd3bd63c04a130407dc5dc88540dbb11da397L473-L487 What's the reason for the removal, and can it be restored? |
Good catch! I don't recall a reason 😆 I opened #891 to restore it. |
Description
Fixes #869
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--884.org.readthedocs.build/en/884/
💡 JupyterLite preview: https://jupytergis--884.org.readthedocs.build/en/884/lite