Skip to content

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Aug 20, 2025

Description

Fixes #869

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--884.org.readthedocs.build/en/884/
💡 JupyterLite preview: https://jupytergis--884.org.readthedocs.build/en/884/lite

@gjmooney gjmooney added the bug Something isn't working label Aug 20, 2025
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/fix_tif_loading

Copy link
Contributor

github-actions bot commented Aug 20, 2025

Integration tests report: appsharing.space

@MMesch
Copy link
Contributor

MMesch commented Aug 20, 2025

Not sure whether it's related to this PR but when I open with the lite demo deployment (in a new private tab) the geotiff-example.tiff in a new qgis project clicking right click on new layer and then open file from server, I get after quite a long loading time this slightly weird image:

image

@MMesch
Copy link
Contributor

MMesch commented Aug 20, 2025

Seems it's to be expected. It loads really slowly but that's a different issue I think.

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use an architecture documentation page for this! LGTM and seems to work fine!

Perhaps the slowness is because this GeoTIFF file only has two levels of overviews.

Check release failure is resolved by #888 !

@mfisher87 mfisher87 merged commit 1a2f469 into geojupyter:main Aug 23, 2025
13 of 14 checks passed
@mfisher87
Copy link
Member

Hey @gjmooney I think part of the performance problem is we used to cache the file's metadata in indexeddb, but we no longer do as of this change: gjmooney@89fd8fb#diff-f155b38648f9ab1ea37e6115e82cd3bd63c04a130407dc5dc88540dbb11da397L473-L487

What's the reason for the removal, and can it be restored?

@gjmooney gjmooney deleted the fix_tif_loading branch August 25, 2025 08:07
@gjmooney
Copy link
Collaborator Author

What's the reason for the removal, and can it be restored?

Good catch! I don't recall a reason 😆 I opened #891 to restore it.

mfisher87 pushed a commit to mapninja/jupytergis-docwork that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geotiff-example.tif and other file geotiffs not loading
3 participants