Skip to content

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Nov 19, 2025

Description

Adds story maps.

I wrote an updated description but github ate it so you just get videos.

storysofar2.mp4

Presentation mode:

presentation.mp4

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--994.org.readthedocs.build/en/994/
💡 JupyterLite preview: https://jupytergis--994.org.readthedocs.build/en/994/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/add_landmarks_as_layer

@martinRenou martinRenou changed the title Add landmarks as layer Add story maps Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

Integration tests report: appsharing.space

@gjmooney gjmooney added the enhancement New feature or request label Nov 19, 2025
@gjmooney gjmooney marked this pull request as ready for review November 19, 2025 16:12
@mfisher87
Copy link
Member

Demo looks great! I would love to have more time to help with a code review... sprinting for a workshop at a huge conference coming up. :( From the demo, the transition speed is really fast. What do you think of reducing it so that users have a better sense of where they are moving? Eventually, I'd love to have that fully configurable by the user, but that feels like a future PR :)

@gjmooney
Copy link
Collaborator Author

CC @mfisher87 I added some options to change the animation duration and style, not sure about 'smooth' as a name though

animations.mp4

@mfisher87
Copy link
Member

Nice! Thanks, Greg! For the future, what do you think of being able to set transition settings for each individual landmark?

@gjmooney
Copy link
Collaborator Author

Nice! Thanks, Greg! For the future, what do you think of being able to set transition settings for each individual landmark?

Yes! I like this idea

@gjmooney gjmooney force-pushed the add_landmarks_as_layer branch 2 times, most recently from 6b6d01e to 58284c1 Compare November 26, 2025 10:55
@gjmooney
Copy link
Collaborator Author

bot please update snapshots

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Some notes:

  • Can you add a story maps example to the list of examples?
  • I got really confused because I created markers and not "landmarks", so I couldn't start my story. I wonder if it would make sense to combine the two? @gjmooney @mfisher87 thoughts?

A bug I noticed, if the image fails to load, the UI is messed up:

Image

Comment on lines 47 to 50
"storyMapPresentation": {
"type": "boolean",
"title": "Enable Story Map Presentations",
"default": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to make this disabled by default?

Maybe we should enable it by default and change the config to match other ones

Suggested change
"storyMapPresentation": {
"type": "boolean",
"title": "Enable Story Map Presentations",
"default": false
"storyMapPresentationDisabled": {
"type": "boolean",
"title": "Disable Story Map Presentations",
"default": false

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I went ahead and made this change because it's not that big of a deal, but considering that presentation mode is going to be off pretty much all of the time in most use cases, having it be on by default seems backwards.

@gjmooney gjmooney force-pushed the add_landmarks_as_layer branch from 6acdad9 to 8a9ef1e Compare December 3, 2025 16:47
@gjmooney
Copy link
Collaborator Author

gjmooney commented Dec 3, 2025

please update snapshots

@gjmooney gjmooney force-pushed the add_landmarks_as_layer branch 2 times, most recently from 6c96289 to e272afa Compare December 5, 2025 12:39
@martinRenou
Copy link
Member

@gjmooney the snapshots issues should be fixed on main. Would you be able to rebase and fix the conflicts?

@gjmooney gjmooney force-pushed the add_landmarks_as_layer branch from e7d7eb5 to c5b83be Compare December 8, 2025 09:43
@gjmooney
Copy link
Collaborator Author

gjmooney commented Dec 8, 2025

bot please update snapshots

@gjmooney
Copy link
Collaborator Author

bot please update snapshots

@gjmooney gjmooney force-pushed the add_landmarks_as_layer branch from 9bedbca to b634016 Compare December 10, 2025 16:43
@gjmooney gjmooney force-pushed the add_landmarks_as_layer branch from 1fd447e to 7bb5d8c Compare December 11, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants