unmounting custom controls#1575
Merged
Falke-Design merged 3 commits intogeoman-io:developfrom Apr 27, 2025
Merged
Conversation
Falke-Design
requested changes
Apr 25, 2025
Collaborator
Falke-Design
left a comment
There was a problem hiding this comment.
Let us add in L.PM.Toolbar the new method deleteControl and make it only callable there. The custom control creation is called over map.pm.Toolbar too.
We don't need a option to delete all controls at once. The user can keep track of the custom controls by him self.
Please revert your changes and add the following code in Toolbar and adjust the type definition.
deleteControl(name) {
const btnName = this._btnNameMapping(name);
if (this.buttons[btnName]) {
this.buttons[btnName].remove();
delete this.buttons[btnName];
}
}
20fe86a to
2fedd39
Compare
Contributor
Author
Yeah, that is actually a better approach. |
Falke-Design
requested changes
Apr 26, 2025
Falke-Design
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is addressing #1407 and this issue
Creating a custom control inside
useEffectwould throw the error 'Button with this name already exists'. This occurs because there was no option to remove the custom button from the toolbar when a component unmounts.codesandbox
This is a crucial feature for the React app as it removes custom components from both the toolbar and the UI. Currently, we only have the
removeControlsfunction, which removes controls from the UI.