Add language fallback tests and enhance language setting logic#1582
Closed
Add language fallback tests and enhance language setting logic#1582
Conversation
- Introduced new Cypress tests to verify language fallback behavior for 2-letter and 3-letter language codes. - Enhanced the `setLang` method in `L.PM.Map` to improve language normalization and fallback handling. - Added logging functionality in Cypress plugins for better debugging.
Falke-Design
requested changes
Apr 29, 2025
Co-authored-by: Florian Bischof <design.falke@gmail.com>
Falke-Design
requested changes
May 1, 2025
Collaborator
Falke-Design
left a comment
Falke-Design
left a comment
There was a problem hiding this comment.
Custom translations are not working anymore:
const customTranslation = {
tooltips: {
placeMarker: "Custom Marker Translation",
},
};
map.pm.setLang("customName", customTranslation, "en"); // -> should change to lang "customName" and add custom language with fallback to "en"
console.log(L.PM.activeLang) // should print "customName"
It should be also possible to add own translations for jam -> replacing customName with jam in the example above
Collaborator
|
@mscno can you please take a look into this again? |
Contributor
Author
|
Closing this one, and fixing with new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setLangmethod inL.PM.Mapto improve language normalization and fallback handling.