Migrate codebase from JavaScript to TypeScript #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert 40 source files from .js to .ts - Keep L.Class.extend() pattern for Leaflet compatibility - Add proper type annotations throughout - Use type assertions for complex runtime types - All unit tests passing (73 tests) - Build compiles successfully
Auto-formatted by oxfmt after migration to match project style
Fix 11 failing tests that were introduced during the TypeScript migration: - Remove stub _isRelevantForRemoval() from Mode.Rotate.ts that was overriding the real implementation from Mode.Removal.ts. This was the root cause of removal mode not working - the mixin system applies mixins in order and Rotate comes after Removal, so the stub method that always returned false was preventing layers from being marked as removable. - Remove stub event fire methods from Mode.Edit, Mode.Drag, and Mode.Rotate that were potentially interfering with the EventMixin implementations. - Add explicit remove() method to L.PM.Edit.Text.ts for the removeIfEmpty functionality which was previously relying on inheritance. All 333 Cypress tests now pass.
mscno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete migration of the leaflet-geoman codebase from JavaScript to TypeScript. This includes all source files in
src/js/and adds proper type definitions.Type of Change
Changes
.js→.ts)Checklist
npm run lint)npm run test:all)Test Results
All 333 Cypress tests pass.