Skip to content

Add get /api/sources/{sourceIdentifier} to be able to get a source by id.#8266

Merged
ianwallen merged 1 commit intogeonetwork:mainfrom
ianwallen:add_get_source_by_id
Jan 29, 2025
Merged

Add get /api/sources/{sourceIdentifier} to be able to get a source by id.#8266
ianwallen merged 1 commit intogeonetwork:mainfrom
ianwallen:add_get_source_by_id

Conversation

@ianwallen
Copy link
Copy Markdown
Contributor

@ianwallen ianwallen commented Jul 18, 2024

Add get /api/sources/{sourceIdentifier} to be able to get a source by id.

image

Moved /api/sources/{type} to Moved /api/sources?type=type as it conflicted with /api/sources/{sourceIdentifier}

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@ianwallen ianwallen added api change Indicate a change in the API backport 4.2.x labels Jul 18, 2024
@ianwallen ianwallen added this to the 4.4.6 milestone Jul 18, 2024
… id.

Moved /api/sources/{type} to Moved /api/sources?type=type as it conflicted with /api/sources/{sourceIdentifier}
@ianwallen ianwallen force-pushed the add_get_source_by_id branch from f00a543 to 240f9b9 Compare July 19, 2024 10:45
@fxprunayre fxprunayre modified the milestones: 4.4.6, 4.4.7 Oct 24, 2024
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine.

The UI has been updated with the API change. @fxprunayre just to confirm if you know users who use this API in third party applications, as they would need to update their applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Indicate a change in the API backport 4.2.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants