Skip to content

Set related children's thumbnail to default 20#8622

Merged
ianwallen merged 2 commits intogeonetwork:mainfrom
wangf1122:main.limit.number.of-children.thumbnails
Feb 26, 2025
Merged

Set related children's thumbnail to default 20#8622
ianwallen merged 2 commits intogeonetwork:mainfrom
wangf1122:main.limit.number.of-children.thumbnails

Conversation

@wangf1122
Copy link
Copy Markdown
Contributor

@wangf1122 wangf1122 commented Jan 27, 2025

Set a limit to rendering the number of children thumbnail. Similar to the card view

image

In some extreme case, the user can set hundreds of children to a parent record and causing some mess to the parent record view page. This issue is discussed in pull request of #8608

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@davidblasby
Copy link
Copy Markdown
Contributor

looking at the page @fxprunayre indicated (https://sdi.eea.europa.eu/catalogue/srv/eng/catalog.search#/metadata/3c362237-daa4-45e2-8c16-aaadfb1a003b).

I see about 133 graphic overview requests - totally about 8mb. Total page load time was 5 seconds. The page was mostly visible after a bit more than 1 seconds.

Based on this, I would expect that setting this to higher than 4 would be fine. Even considering base64 encoding, this would increase the size of the document by 10.5mb (for 133 overviews).

cf. #8608

Copy link
Copy Markdown
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangf1122 I think increasing it to 20 should be fine, as suggested by @ianwallen in #8608 (comment)

@wangf1122
Copy link
Copy Markdown
Contributor Author

@josegar74 @ianwallen

I have change the thumbnail display to 20 here. Please check

@wangf1122 wangf1122 requested a review from josegar74 February 21, 2025 14:46
Copy link
Copy Markdown
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't test it, but looks a reasonable value.

@ianwallen ianwallen merged commit 6a36be5 into geonetwork:main Feb 26, 2025
7 checks passed
@josegar74 josegar74 changed the title Set related children's thumbnail to default 4 Set related children's thumbnail to default 20 Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants