Open
Conversation
Contributor
Author
|
elastic doc on this option: |
josegar74
reviewed
Feb 5, 2025
| // the thesaurus already exists. This will clean up and there will not be a problem on the next run. | ||
| // This is typically only an issue if you are running the test locally - on the build server it gets a | ||
| // new, clean, filesystem so there isn't a problem. | ||
| var uploadedThesauras = geonetworkDataDirectory.resolveWebResource( |
Member
There was a problem hiding this comment.
I would not use var as probably we have to backport this to 4.2.x, please change to use Path and add the import.
Member
There was a problem hiding this comment.
@davidblasby please check the previous comment to update the code, so the pull request can be merged, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does the following:
Set the integration test's elastic so it will NOT give
low disk watermarkerror messages and refuse to start if your disk is >90% full.core/services/Set
servicesso that it runs on a single JVM. This was because elastic is shared between all the different test cases - some tests were modifying the data at the same time (cf Formatter / Use portal filter #8263), causing inconsistencies as to the uuid of metadata recordid=100.services/. However, the slowdown was very small on my local computer. This is something to keep an eye on.KeywordsApiTest#testImportOntologyToSkosuploaded a file - this would be written (by the ThesaurusManager) to the file system (WEB-INF). On the next run, the test would give an error saying the thesaurus already exisitsThis is problematic on development machines with low disk available (>90% full), and quite difficult to remedy.
I suspect that this hasn't been noticed because the build server;
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation