URL Decode filename for resources uploaded by url

[tylerjmchugh]

Currently the putResourceFromUrl API gets the file name from the URL itself but does not consider URL encoded characters. This means if a URL like http://domain.com/dictionnaire%20de%20donn%C3%A9es.pdf is provided the uploaded file's name will be dictionnaire%20de%20donn%C3%A9es.pdf.

This PR aims to fix this issue by URL decoding the filename. With this fix the filename would be dictionnaire de données.pdf as intended.

Checklist

• I have read the contribution guidelines
• Pull request provided for main branch, backports managed with label
• Good housekeeping of code, cleaning up comments, tests, and documentation
• Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
• Clean commit messages, longer verbose messages are encouraged
• API Changes are identified in commit messages
• Testing provided for features or enhancements using automatic tests
• User documentation provided for new features or enhancements in manual
• Build documentation provided for development instructions in README.md files
• Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

[josegar74]

It works fine.

Please @tylerjmchugh can you check to add a test in https://github.com/geonetwork/core-geonetwork/blob/main/core/src/test/java/org/fao/geonet/api/records/attachments/FilesystemStoreTest.java

    @Test
    public void testGetFilenameFromUrl() throws Exception {
        FilesystemStore filesystemStore = new FilesystemStore();

        String fileName = filesystemStore.getFilenameFromUrl(new URL("http://mydomain.com/filename.txt"));
        assertEquals("filename.txt", fileName);

        fileName = filesystemStore.getFilenameFromUrl(new URL("http://mydomain.com/filename%20with%20spaces.txt"));
        assertEquals("filename with spaces.txt", fileName);
    }