API / Keyword search by id / Do not decode URI parameter#8636
Open
fxprunayre wants to merge 2 commits intomainfrom
Open
API / Keyword search by id / Do not decode URI parameter#8636fxprunayre wants to merge 2 commits intomainfrom
fxprunayre wants to merge 2 commits intomainfrom
Conversation
Searching keyword having + in URI was returning nothing eg. https://www.iana.org/assignments/media-types/application/geopackage+sqlite3 (and the editor was not adding the selected keywords). API call properly encode parameters cf. https://github.com/geonetwork/core-geonetwork/blob/main/web-ui/src/main/resources/catalog/components/thesaurus/ThesaurusService.js#L364-L366 Spring is decoding URL parameters. Can be tested with https://github.com/metadata101/dcat-ap/blob/main/resources/thesauri/theme/media-types.rdf Was added in 0423a22
`gnUrlUtils.toKeyValue` takes care of encoding.
|
joachimnielandt
approved these changes
Feb 5, 2025
Contributor
joachimnielandt
left a comment
joachimnielandt
left a comment
There was a problem hiding this comment.
Tested locally, works fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching keyword having + in URI was returning nothing eg. https://www.iana.org/assignments/media-types/application/geopackage+sqlite3 (and the editor was not adding the selected keywords).
API call properly encode parameters cf. https://github.com/geonetwork/core-geonetwork/blob/main/web-ui/src/main/resources/catalog/components/thesaurus/ThesaurusService.js#L364-L366
Spring is decoding URL parameters.
Can be tested with https://github.com/metadata101/dcat-ap/blob/main/resources/thesauri/theme/media-types.rdf
Was added in 0423a22
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation