Public permalink to private md by cmangeat · Pull Request #9059 · geonetwork/core-geonetwork

cmangeat · 2025-10-07T08:22:17Z

Allow a gn admin to get a 'token' which can be used by an anonymous user to have a read access to a non published md and to its resources (for reviewing purposes). Each time the token is used once in an http session as a request parameter, it grants the session the extra authorization if not already granted.

Extra granted authorizations/tokens can be created from simple view, revoked from simple view, listed from admin menu, revoked from list.

Extra granted authorizations cannot be created for published md, publishing an md revoke its associated link if one.

Token has two parts, a "hash", stored encrypted in db, and the md uuid, so not to have to decrypt all the db stored hash when checking for validity, match is performed against the stored hash corresponding to the uuid (encryption algorithm forbid comparaison of same hash encrypted twice, encrypting the hash twice return two different results, only checking for match is possible).

published md:

private md with no right granted:

granting access (hash is displayed only once):

private md with access granted:

granted access list:

Checklist

Funded by IRD

josegar74

Please, can you add a description to describe the change request.

core/src/main/java/org/fao/geonet/kernel/security/ViewMdGrantedAuthority.java

core/src/main/java/org/fao/geonet/security/GrantViewMdAuthorityFilter.java

core/src/test/java/org/fao/geonet/kernel/search/EsFilterBuilderTest.java

core/src/test/java/org/fao/geonet/kernel/security/ResourceLibCheckPrivilegeTest.java

core/src/test/java/org/fao/geonet/security/GrantViewAuthorityFilterTest.java

domain/src/main/java/org/fao/geonet/domain/AnonymousAccessLink.java

domain/src/main/java/org/fao/geonet/repository/AnonymousAccessLinkRepository.java

domain/src/test/java/org/fao/geonet/repository/AnonymousAccessLinkRepositoryTest.java

services/src/main/java/org/fao/geonet/api/anonymousAccessLink/AnonymousAccessLinkApi.java

services/src/test/java/org/fao/geonet/api/anonymousAccessLink/AnonymousAccessLinkApiTest.java

pmauduit

Some minor comments here, looks good globally.

Is it on purpose that the feature is reserved to administrators ? I would have expected that some Editors, reviewers, admin_users could also have the need to share their work.

core/src/main/java/org/fao/geonet/security/GrantViewMdAuthorityFilter.java

services/src/main/java/org/fao/geonet/api/anonymousAccessLink/AnonymousAccessLinkApi.java

services/src/main/java/org/fao/geonet/api/anonymousAccessLink/AnonymousAccessLinkService.java

services/src/main/java/org/fao/geonet/api/anonymousAccessLink/AnonymousAccessLinkApi.java

jodygarnett

Any new feature PRs requires documentation. It can be very minimal just to note the feature exists; but we want something :)

I really like this feature, when I have seen similar features in other products they may have a timeout associated with the token, or were associated with a specific email address. That may be overkill for the intension of sharing an edit already in progress.

jodygarnett · 2026-01-05T19:42:20Z

Ideas for discussion.

Share Record Preview / Remove Record Preview

The name of the feature "createAnonymousAccess" and "deleteAnonymousAccess" obviously needs to be internationalized. May I suggest a wording change of "Share Record Preview", and "Remove Record Preview". I think that would match the intended use, and "delete" tends to indicate something is gone forever. "Share Draft Record" / "Remove Draft Record" may also work and match up with the state in the review workflow better.

Record Preview Banner

When viewing a record preview, it would be great to have an overlay or underlay indicating this is a "preview" and not official. You some times see that in documents written as "DRAFT".

cmangeat · 2026-01-08T09:37:08Z

Taking into account https://docs.geonetwork-opensource.org/4.4/user-guide/workflow/life-cycle/#record-life-cycle, in order to avoid confusion, we choose not to use "draft" term as it could remind of workflow and we prefer "Share unpublished record preview".

cmangeat · 2026-01-19T17:31:18Z

Any new feature PRs requires documentation. It can be very minimal just to note the feature exists; but we want something :)

I really like this feature, when I have seen similar features in other products they may have a timeout associated with the token, or were associated with a specific email address. That may be overkill for the intension of sharing an edit already in progress.

…e anymore

not existing link deletion test

…pository only if viewMdAuthority is granted

choosen encryption algorithm forbid comparaison of same hash encrypted twice, have to first fecth stored crypted hash corresponding to uuid, then to check for match.

Co-authored-by: Pierre Mauduit <pmauduit@users.noreply.github.com> Co-authored-by: Pierre Mauduit <pmauduit@users.noreply.github.com> Co-authored-by: Pierre Mauduit <pmauduit@users.noreply.github.com> Co-authored-by: Pierre Mauduit <pmauduit@users.noreply.github.com> Co-authored-by: Pierre Mauduit <pmauduit@users.noreply.github.com>

jahow

Final approval since all comments have been addressed. Thanks again for this great feature @sebr72 and @cmangeat

Note: this was discussed in today's GN4 community meeting

josegar74 reviewed Oct 8, 2025

View reviewed changes

cmangeat force-pushed the public_permalink_to_private_md branch 5 times, most recently from a45c663 to 9040494 Compare October 15, 2025 12:06

cmangeat force-pushed the public_permalink_to_private_md branch 4 times, most recently from 8a077fe to 2f4a5ab Compare October 17, 2025 14:08

cmangeat force-pushed the public_permalink_to_private_md branch 2 times, most recently from 5ac61b1 to c240e76 Compare October 26, 2025 14:53

cmangeat marked this pull request as ready for review October 30, 2025 10:49

PascalLike requested review from fxprunayre, jahow and josegar74 November 19, 2025 16:26

jahow requested a review from pmauduit December 19, 2025 14:36

pmauduit approved these changes Dec 19, 2025

View reviewed changes

cmangeat force-pushed the public_permalink_to_private_md branch 2 times, most recently from bf301e6 to 2ee7d31 Compare December 24, 2025 10:51

jodygarnett requested changes Jan 5, 2026

View reviewed changes

cmangeat force-pushed the public_permalink_to_private_md branch from 1a6fd9b to a5d99d0 Compare January 19, 2026 16:33

sebr72 force-pushed the public_permalink_to_private_md branch 2 times, most recently from a3a2c99 to 57295d3 Compare January 19, 2026 17:06

cmangeat requested a review from jodygarnett January 19, 2026 17:30

cmangeat closed this Jan 19, 2026

cmangeat reopened this Jan 19, 2026

cmangeat and others added 27 commits February 5, 2026 10:09

add headers

a1d14b1

service nominal test

46bc207

always hide hash but when create

9be115d

by now, api return dto, not entity

995bb11

test for delete with service

2b8055b

does a link exist service

763d625

refactor test

bdbdfcf

does a link exist api

b876ab7

refactor test

ed214dd

do not include null field (hash) when json serialize

440237b

delete and create now take a md uuid as path param, no body to provid…

a6dbf65

…e anymore

refactor test

bebdfd7

service to return links bound with md info

d1354b6

fix test

d1fd5d2

at this point, two links cannot give access to the same md

f7b8cde

trigger link deletion when md published

64ab7ef

not existing link deletion test

make anonymous session not anonymous for httpSessionSecurityContextRe…

9be3d7a

…pository only if viewMdAuthority is granted

create anonymous access link does not operate for published md

5138012

missing headers

e1d8e76

create and revoke anonymous access from record action menu

88b6e82

list anonymous accesses from tools with delete button

dea4a9a

encrypt hash in db

1a98928

choosen encryption algorithm forbid comparaison of same hash encrypted twice, have to first fecth stored crypted hash corresponding to uuid, then to check for match.

hyphenated package name

dede449

introduce paramCannotBeSplitIntoHashAndUuid variable

3669768

Better translations (english / french)

56c4520

Add documentation in user manual

bffca75

cmangeat force-pushed the public_permalink_to_private_md branch from 208a7f5 to bffca75 Compare February 5, 2026 09:11

jahow approved these changes Feb 11, 2026

View reviewed changes

jahow merged commit c98c394 into geonetwork:main Feb 11, 2026
8 checks passed

Uh oh!

Conversation

cmangeat commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

josegar74 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pmauduit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jodygarnett left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jodygarnett commented Jan 5, 2026

Share Record Preview / Remove Record Preview

Record Preview Banner

Uh oh!

cmangeat commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmangeat commented Jan 19, 2026

Uh oh!

jahow left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmangeat commented Oct 7, 2025 •

edited

Loading

josegar74 left a comment •

edited

Loading

jodygarnett left a comment •

edited

Loading

cmangeat commented Jan 8, 2026 •

edited

Loading

jahow left a comment •

edited

Loading