[backport 2.4.3] [Datahub] Fix Links Section Display in record

[LPoin]

Description

This PR fix the filter of links section disply in record "reuse".
The application should display the links if they exist in the record, reuse or not, as it worked before v2.4
Linked to issue-1169

Architectural changes

Filter modified in mdview-facade.ts to get links in reuse record.
If needed, the filter can be remove but this implies a change in the typing of the elements returned, and therefore deeper changes in the code.

Screenshots

Before

After

Quality Assurance Checklist

• Commit history is devoid of any merge commits and readable to facilitate reviews
• If new logic ⚙️ is introduced: unit tests were added
• If new user stories 🤏 are introduced: E2E tests were added
• If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
• If breaking changes 🪚 are introduced: add the breaking change label
• If bugs 🐞 are fixed: add the backport <release branch> label
• The documentation website 📚 has received the love it deserves

How to test

Open a interactiveMap or map record, see the links displayed in the right section

---

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jahow]

I think you can just remove the condition on the record kind; this was there for historical reasons but now all records have an onlineResources property

[jahow]

Also could you please add a test for this? thanks!

[LPoin]

Yes as I said, allLinks$ return a Observable<DatasetOnlineResource[]> but if I remove record.kind === 'dataset', it return a Observable<DatasetOnlineResource[] | ServiceOnlineResource[]>.
So everywhere it used it create a typing error.
I could fix that but It's likely to change the code to an extent I'm not familiar with.

[jahow]

Oh right... Then ok your change makes sense. 🙂 Please let us know if you need help for the test

[LPoin]

Thanks I'll see it and let you know !

[LPoin]

Hello @jahow I get back to you to find out what type of test to add.
In mdview.facade.spec.ts existing tests seems to cover all requirements and passes correctly.