Skip to content

Conversation

@mmohadIGN
Copy link
Contributor

Description

This PR revises the protocol detection for the GPFDL component to align with INSPIRE standards. It now supports data filtering by date and facilitates the bulk downloading of files associated with a subresource.

Architectural changes

Screenshots

image
image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

How to test

You can test using our database. I recommend using the Plan IGN for testing all the filters. However, please note that in our production environment, not all our metadata are correctly aligned with the proper protocol yet.


@coveralls
Copy link

Coverage Status

coverage: 84.477% (+3.1%) from 81.421%
when pulling 97655e6 on IGNF:GPFDL-IGN_PR_2
into 47d0cd1 on geonetwork:main.

@LHBruneton-C2C
Copy link
Collaborator

Hi @mmohadIGN,

This PR has been open for a few months now.
Do you still intend to have it merged?
What's preventing you from moving forward?

Thanks for you contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants