Fix search and results wc records catalog redirection #1433
+28
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @maxcollombin, thanks for sharing this PR! I think you are trying to fix 2 issues at once, #1406 and #1407. I had a look at your branch, and although it does seem to fix #1407, there is also unneeded changes for this specific fix. Could you try to isolate your fix for #1407, this way it will be easier to accept and move forward to properly fixing #1406. Thanks! |
maxcollombin
force-pushed
the
fix/search-and-results-wc
branch
from
cdc104e to
8c34f1a
Compare
Contributor
Author
|
Hi @LHBruneton-C2C, Thanks for your reply. I've updated the PR accordingly. |
maxcollombin
force-pushed
the
fix/search-and-results-wc
branch
from
8c34f1a to
78517f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1407