Skip to content

Add --no-use-pep517 to get around pip oldest-supported-numpy issue #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2022
Merged

Add --no-use-pep517 to get around pip oldest-supported-numpy issue #108

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afc0592
Add --no-use-pep517 to get around pip oldest-supported-numpy issue
brendan-ward May 16, 2022
ae255db
remove --no-build-isolation and use default pip install for docker gd…
brendan-ward May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-gdal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
run: |
python3 -m pip install --no-cache-dir -U pip wheel
python3 -m pip install --no-cache-dir cython~=0.29
python3 -m pip install --no-cache-dir --no-build-isolation -e .[dev,test,geopandas]
python3 -m pip install --no-cache-dir --no-build-isolation --no-use-pep517 -e .[dev,test,geopandas]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could also remove the --no-build-isolation altogether and test the default pip installation in this workflow (and then we can also remove the cython install step on the line above)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's cleaner.


- name: Test with pytest
run: |
Expand Down