-
Notifications
You must be signed in to change notification settings - Fork 3
feat(MapsetKmlFormat): add methods for reading and writing <Document> properties in KML strings #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danji90
wants to merge
13
commits into
master
Choose a base branch
from
daniel/kmlDocumentProperties
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(MapsetKmlFormat): add methods for reading and writing <Document> properties in KML strings #233
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c8de70a
fix(MapsetKmlFormat): extend functionality to support feature scaling…
danji90 9140165
Merge branch 'master' into daniel/enhanceMapsetKmlFormat
danji90 1935bdd
chore: add scaleOptions for all geom types in MapsetKmalFormat
danji90 808dfaf
chore(release): 3.4.6-beta.0
danji90 b35012f
chore: merge master
danji90 98b7496
feat(MapsetKmlFormat): add methods for reading and writing <Document>…
danji90 b2ddb81
chore(release): 3.5.0-beta.0
danji90 4f15d6f
chore: make getDocumentProperty function more generic
danji90 9fbce89
chore(release): 3.5.0-beta.1
danji90 317560b
chore: revert version
danji90 711a215
chore(release): 3.5.0-beta.1
danji90 3def45b
chore: merge master
danji90 dd13012
chore: remove ticket specific code
danji90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you never use this method, so if it is a utility method for Mapset . Creates someting more generic, so we could use it like this , when we need it (with good type for the parameter):
getDocumentProperty("name")
getDocumentProperty("description")
getDocumentProperty("zoomLimits")
it will be easier to maintain if we add more properties.