Skip to content

encode content before counting#1092

Merged
tomkralidis merged 1 commit intogeopython:masterfrom
pvgenuchten:fix_content_length
Mar 5, 2025
Merged

encode content before counting#1092
tomkralidis merged 1 commit intogeopython:masterfrom
pvgenuchten:fix_content_length

Conversation

@pvgenuchten
Copy link
Copy Markdown
Contributor

Overview

python counts string length differently when having special characters, therefore an incorrect content length is sent, and the request is truncated, count is correct if it is first encoded

Related Issue / Discussion

fixes #1091

Additional Information

to be discussed if it makes sense to return also the content itself encoded

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

encode content before counting
@pvgenuchten pvgenuchten requested a review from tomkralidis March 5, 2025 15:14
@tomkralidis tomkralidis added the bug label Mar 5, 2025
@tomkralidis tomkralidis added this to the 3.0.0 milestone Mar 5, 2025
@tomkralidis tomkralidis merged commit c1b6157 into geopython:master Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ogcapi-records] html is cut off at random values

2 participants