safeguard some properties #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
requested changes
Oct 28, 2025
pvgenuchten
force-pushed
the
escape-missing-import-params
branch
2 times, most recently
from
d50e748 to
6f3b193
Compare
tomkralidis
requested changes
Oct 29, 2025
| }], | ||
| 'temporal': [] | ||
| } | ||
| except: |
Member
There was a problem hiding this comment.
What is the except triggered by? A KeyError? Suggest to include the error type and log a message, i.e.
except KeyError as err:
LOGGER.info(f'boundingBox parsing failed: {err}')
pvgenuchten
force-pushed
the
escape-missing-import-params
branch
2 times, most recently
from
8ec2666 to
6a2d2f5
Compare
pvgenuchten
commented
Oct 31, 2025
| :returns: dict of MCF contact | ||
| """ | ||
|
|
||
| if isinstance(contact, list): |
Contributor
Author
There was a problem hiding this comment.
i had to add this check, else tests fail, not sure how this can contact can be a list in some cases
pvgenuchten
force-pushed
the
escape-missing-import-params
branch
2 times, most recently
from
64467a9 to
ad2dbf4
Compare
safeguard $graph remove utc reference
pvgenuchten
force-pushed
the
escape-missing-import-params
branch
from
ad2dbf4 to
e82bb3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #285
resolves #286
resolves #287