Skip to content

Conversation

@pvgenuchten
Copy link
Contributor

mcf had some duplication in the attributes section, maybe it was kept at its old location for backwards compatibility?
suggestion to clean up the second instance

also a suggestion to extend sample with more relevant content
extend the field types with date and datetime

@pvgenuchten
Copy link
Contributor Author

pvgenuchten commented Oct 31, 2025

Some discussion about the expected values in the type property of attributes. From the json-schema perspective the typical json types would be expected (and date would be a formatter of string). However from a iso19110/iso19103 perspective typical valueTypes expected are:
image
suggestion could be to add a (optional) paremeter valueType (from Attribute.FC_FeatureAttribute.vaIueType)

@pvgenuchten pvgenuchten force-pushed the clean_up_duplicate_attrs branch from 0b3d021 to d6317a2 Compare October 31, 2025 12:49
@tomkralidis tomkralidis merged commit 016804e into geopython:master Oct 31, 2025
1 check passed
@pvgenuchten pvgenuchten deleted the clean_up_duplicate_attrs branch October 31, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants