#230 - Use static path to find provider button's img#235
Merged
Gaetanbrl merged 1 commit intogeorchestra:mainfrom Nov 14, 2025
Merged
#230 - Use static path to find provider button's img#235Gaetanbrl merged 1 commit intogeorchestra:mainfrom
Gaetanbrl merged 1 commit intogeorchestra:mainfrom
Conversation
f-necas
reviewed
Nov 6, 2025
Collaborator
f-necas
left a comment
There was a problem hiding this comment.
You may have overengineered it.
You can access statc Location with :
@Autowired(required = false)
private WebProperties webProperties;
String[] locations = webProperties.getResources().getStaticLocations();
// ["classpath:/META...", "classpath:/reso...", "classpath:/stat...", "classpath:/publ...", "file:/home/..."]
Then we could iterate through paths in order to see in ClassPathResource if start with classpath: or FileSystemResource if start with file: .
This way we can order the lookup locaiton we want using the spring properties.
spring:
web:
resources:
static-locations: file:/etc/georchestra/gateway/resources/static/, classpath:/static/
pierrejego
requested changes
Nov 14, 2025
gateway/src/main/java/org/georchestra/gateway/app/LoginLogoutController.java
Show resolved
Hide resolved
325b1f4 to
e2099a6
Compare
Contributor
Author
|
J'ai apporté les changements suite aux revues. Je reste en attente de retours. |
f-necas
reviewed
Nov 14, 2025
gateway/src/main/java/org/georchestra/gateway/app/StaticResourcesUtils.java
Show resolved
Hide resolved
f-necas
reviewed
Nov 14, 2025
gateway/src/main/java/org/georchestra/gateway/app/StaticResourcesUtils.java
Show resolved
Hide resolved
f-necas
approved these changes
Nov 14, 2025
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-actions bot
added a commit
that referenced
this pull request
Nov 14, 2025
[2.0.x] Merge pull request #235 from jdev-org/issue-230-button-provider-img
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR Introduced ProviderLogoResolver to centralize OAuth logo lookups according to datadir static directory (overrides) :
https://docs.georchestra.org/gateway/en/latest/user_guide/ui_customization/?h=thym#static-resources
Here an example to use a custom png with franceconnect (boat) :
How to test ?
in application.yaml, replace :
By :
datadir/gateway/templates/static/imgExample, if you set a
franceconnectprovider, use a png namesfranceconnect.pngintemplates/staticdirectory.