chore: remove deprecated x-frame-options header#262
Open
Conversation
f-necas
approved these changes
Mar 25, 2026
pmauduit
changed the title
x-frame-options header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove/Disable x-frame-options because it is deprecated: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Frame-Options
As per explained by the MDN doc, one should instead configure the iframe policy using the Content Security Policy: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Security-Policy/frame-ancestors
The benefit is that through the CSP, one can allow multiple website to load the iframe from. Whereas with x-frame-options you are limited to only one website.
The removal also makes it easier for the final application (GeoServer, Geonetwork, ...) to handle this case itself through the CSP if needed. Thus, not relying on the GW to set the iframe permissions.
Security wise, it allows the iframe to be controlled per component and not on all applications (can be a security issue for the geOrchestra console for example).