Skip to content

Conversation

@swetavooda
Copy link
Contributor

Issue with old approach

  1. Validating large vectors to verify if they are zero-vectors would slow down insertion.
  2. Validating every vector on insert + flushing + build would be redundant and slows down the insertion
  3. The old approach throws an error to the user which blocks the user from inserting the remaining vectors in the buffer if a zero-vector is encountered. Which is a bad experience for the users which requires manual effort to remove the zero-vectors

Solution:

  1. Validate only on flushing + build time.
  2. Do not block user with error. Continue to flush remaining tuples in buffer and display a WARNING.

@swetavooda swetavooda force-pushed the feature/zero-vector-opt branch from 5d4aa45 to 229b9c1 Compare April 22, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant