Merged
Conversation
Added a badge to docs.rs/geotiff, updated note about significant refactoring work on top of tiff crate, and refreshed the library usage code example.
Using git-cliff to generate a draft changelog, grouped into different sections based on GitHub PR labels. Manually edited to use Pull Request title for changelog entries in v0.1.0, and removing the miscellaneous category containing entries from non-squashed commits.
gschulze
requested changes
Jun 10, 2025
Collaborator
gschulze
left a comment
gschulze
left a comment
There was a problem hiding this comment.
Found a small documentation inconsistency, looks fine otherwise!
README.md
Outdated
| ``` | ||
|
|
||
| `TIFF::open(...)` returns an `Option`, depending if the open operation was successful or not. Individual values can then be read (for the moment, only at pixels) using: | ||
| `GeoTiff::read(...)` returns an `Option`, depending if the read operation was successful |
Collaborator
There was a problem hiding this comment.
Actually, this now returns a TiffResult<Self>.
Member
Author
There was a problem hiding this comment.
Oh yes, good catch! Edited at commit fd1b499, see if it looks ok now.
Co-authored-by: Gunnar Schulze <gunnar.schulze@invenium.io>
gschulze
approved these changes
Jun 10, 2025
Member
Author
|
Thanks @gschulze, I'll tag a release, and then publish to crates.io in a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for publishing a v0.1.0 to crates.io!
TODO:
CHANGES.mdorCHANGELOG.mdCloses #28, #7