Enable use of ExtData2G in GCHP Transport Tracers simulation#41
Open
Enable use of ExtData2G in GCHP Transport Tracers simulation#41
Conversation
This fix was submitted by Ben Auer (NASA GMAO) Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This fix is being applied by GMAO in a dev version of MAPL2 beyond MAPL 2.59 currently used in GCHP. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This makes ExtData2G convert at import file 3D data that is top-down to bottom-up prior to exporting to GCHP gridded components. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This is necessary to determine the vertical orientation of GEOS-Chem processed meteorology files which are not CF-compliant. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a fix from Ben Auer (NASA GMAO) for a bug found by me and reported in GEOS-ESM#4158. Ben's PR to the upstream MAPL repository is at GEOS-ESM#4160.
The bug was in adding imports to ExtData for fields that are vectorized. When one of the two names in an ExtData2G rule for a vector, e.g.
UA;VA, is contained in a substring in another item, e.g.EVAP,there would be an ESMF error that is was already added.