Fixes for offline regridding and stretched grid plotting#381
Merged
Conversation
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This is a temporary fix to prevent users from passing an output template file that differs in dimension sizes from the target grid size when doing offline regridding. Code exists to reside the output template but it currently does not work. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Native precision of source restart file should be preserved. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
added
topic: Regridding
yantosca
approved these changes
Oct 6, 2025
Contributor
|
Thanks @lizziel. Good to merge! |
yantosca
added a commit
that referenced
this pull request
Oct 6, 2025
This merge brings updates from the "dev" branch (as of PR #381) back into the "feature/update-constants" branch. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
deleted the
bugfix/offline_regridding_and_stretch_grid_plotting_fixes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This update applies the following changes to offline regridding code in function
regrid_restart_file. That function is currently used to create GCHP stretched grid restart files via offline regridding.update_encodingwhich previously converted all restart variables to floating point precision. Precisions of the source restart file should instead be preserved, e.g. double precision for species concentrations.This PR also fixes the names of stretched grid target latitude and longitude attributes used in plotting code. This bug crept in during recent development and is not part of an existing release. It is therefore not mentioned in the changelog.
Expected changes
This update fixes plotting of stretched grid restart variables and makes GCHP restarts regridding using offline regridding better match restart generated using online regridding (GCPy function
regrid_file). Note that the restarts for these two methods do not exactly match. That is currently under investigation.Reference(s)
None
Related Github Issue
None