Conversation
yantosca
added
topic: Benchmark Plots and Tables
gcpy/benchmark/modules/run_1yr_fullchem_benchmark.py - Make sure that "spcdb_files" is passed as the 7th argument to make_benchmark_operations_budget (following "dev_interval") - Trimmed trailing whitespace gcpy/benchmark/run_benchmark.py - Pass "colname" as the 5th argument to routines "make_benchmark_collection_2d_var_plots" and "make_benchmark_collection_3d_var_plots" (preceding "spcdb_files") - Make sure that "spcdb_files" is passed as the 7th argument to make_benchmark_operations_budget (following "dev_interval") - Removed a duplicate import of "make_benchmark_operations_budget" - Trimmed trailing whitespace CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
force-pushed
the
bugfix/collection-var-plots
branch
from
5fbb1b3 to
fd4bdec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR does the following:
Updates calls to
make_benchmark_operations_budgetinrun_benchmark.pyandrun_1yr_fullchem_benchmark.pyso thatspcdb_filesis passed as the 7th argument.Updates calls to
make_benchmark_collection_2d_var_plotsandmake_benchmark_collection_3d_var_plotsinrun_benchmark.pyso thatcolnameis passed as the 5th argument.Removes a duplicate import of
make_benchmark_operations_budgetfromrun_benchmark.pyTrims trailing whitespace in a few locations.
Expected changes
This will not affect GEOS-Chem benchmarks, as the operations budget and collections variable plots are typically not generated. However it will fix the code so that users who wish to use these routines will be able to do so.