Skip to content

Conversation

@congchen1101
Copy link
Contributor

@congchen1101 congchen1101 commented Sep 9, 2024

Enhanced Customization for Highlight Styles in Feature Selection

  • Enabled defining highlightStyle objects under Map and Identify sections in localConfig.json to allow customization of highlight styles.
  • Updated and added relevant tests to reflect these changes.

On behalf of DB Systel GmbH

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Enhanced Customization for Highlight Styles in Feature Selection
- Enabled defining `highlightStyle` objects under `Map` and `Identify` sections in localConfig.json to allow customization of highlight styles.
- Updated and added relevant tests to reflect these changes.

On behalf of DB Systel GmbH
@tdipisa
Copy link
Member

tdipisa commented Sep 10, 2024

Dear @congchen1101
thank you so much for your contribution. Is it possible for you to put some screenshots and/or small video in the PR description to show how the functionality you have implemented works and to see how it looks? This will help us with the review. Thank you so much again.

@tdipisa tdipisa changed the title #10536 Enhanced Customization for Highlight Styles in Feature Selection Sep 10, 2024
@tdipisa tdipisa modified the milestones: 2025.01.00, 2025.02.00 Jun 12, 2025
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 4, 2025
@tdipisa tdipisa added backport 2025.02.xx and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Dec 12, 2025
@tdipisa tdipisa requested review from dsuren1 and removed request for allyoucanmap December 18, 2025 09:41
@tdipisa tdipisa assigned dsuren1 and unassigned allyoucanmap Dec 18, 2025
@dsuren1 dsuren1 modified the milestones: 2025.02.01, 2025.02.02 Dec 18, 2025
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@congchen1101
Thank you for your contribution.

Before I proceed with a detailed review, the PR would need to be aligned with the latest master, as there are currently some conflicts with the Map component. I also noticed that the application crashes when the Map viewer is loaded. It might be worth reviewing the IdentifyContainer, as the use of recompose can sometimes interfere with React Hooks. You could consider initializing the plugin configuration directly here

Additionally, based on the issue description, it appears the objective is to provide a highlight style for features selected from the Feature Editor. In that case, would it be possible to explore passing this configuration directly to the FeatureEditor, rather than modifying the core Map component?

@tdipisa
Copy link
Member

tdipisa commented Jan 5, 2026

@congchen1101 remind to also fix conflicts. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhanced Customization for Highlight Styles in Feature Selection

4 participants