-
Notifications
You must be signed in to change notification settings - Fork 444
Enhanced Customization for Highlight Styles in Feature Selection #10537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enhanced Customization for Highlight Styles in Feature Selection #10537
Conversation
Enhanced Customization for Highlight Styles in Feature Selection - Enabled defining `highlightStyle` objects under `Map` and `Identify` sections in localConfig.json to allow customization of highlight styles. - Updated and added relevant tests to reflect these changes. On behalf of DB Systel GmbH
|
Dear @congchen1101 |
dsuren1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@congchen1101
Thank you for your contribution.
Before I proceed with a detailed review, the PR would need to be aligned with the latest master, as there are currently some conflicts with the Map component. I also noticed that the application crashes when the Map viewer is loaded. It might be worth reviewing the IdentifyContainer, as the use of recompose can sometimes interfere with React Hooks. You could consider initializing the plugin configuration directly here
| onInitPlugin({ |
Additionally, based on the issue description, it appears the objective is to provide a highlight style for features selected from the Feature Editor. In that case, would it be possible to explore passing this configuration directly to the FeatureEditor, rather than modifying the core Map component?
|
@congchen1101 remind to also fix conflicts. Thank you for your contribution. |
Enhanced Customization for Highlight Styles in Feature Selection
highlightStyleobjects underMapandIdentifysections in localConfig.json to allow customization of highlight styles.On behalf of DB Systel GmbH
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)