Skip to content

Conversation

@landryb
Copy link
Contributor

@landryb landryb commented Mar 12, 2025

Description

totally WIP. failed to load the layer, but at least it was detected as a candidate in the array of dc:URI.

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#10926

What is the new behavior?

loading 3dtiles from csw searchs work in more cases (but only allows to load the first 3dtiles link) .
accounts for the case when dc:URI and dc:format are arrays.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@landryb landryb marked this pull request as draft March 12, 2025 14:26
@landryb
Copy link
Contributor Author

landryb commented Mar 12, 2025

the example im using for testing:

    <csw:Record xmlns:gmx="http://www.isotc211.org/2005/gmx" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:ows="http://www.opengis.net/ows" xmlns:geonet="http://www.fao.org/geonetwork" xmlns:dct="http://purl.org/dc/terms/">
      <dc:identifier>a1b0f173-769a-479e-be2f-de8472d2ea96</dc:identifier>
      <dc:date>2025-03-12T14:17:15.777315134Z</dc:date>
      <dc:title>Parcelle</dc:title>
      <dc:type>series</dc:type>
      <dc:subject>Parcelles cadastrales</dc:subject>
      <dc:subject>planningCadastre</dc:subject>
      <dc:format>3D Tiles</dc:format>
      <dct:abstract>xx</dct:abstract>
      <dc:description>xx</dc:description>
      <dc:rights>otherRestrictions</dc:rights>
      <dc:language>eng</dc:language>
      <dc:source>xx2</dc:source>
      <dc:format>3D Tiles</dc:format>
      <ows:BoundingBox crs="urn:ogc:def:crs:EPSG:6.6:4326">
        <ows:LowerCorner>43.990591108689124 7.042186562984941</ows:LowerCorner>
        <ows:UpperCorner>44.07286703776547 7.135829595268829</ows:UpperCorner>
      </ows:BoundingBox>
      <dc:URI protocol="" name="PARCELLE" description="Parcelles 1">https://georchestra.dev.craig.fr/geoserver/psc/ows?SERVICE=WMS&amp;REQUEST=GetCapabilities</dc:URI>
      <dc:URI protocol="OGC:WFS" name="PARCELLE" description="Parcelles 1 - WFS">https://georchestra.dev.craig.fr/geoserver/psc/ows?SERVICE=WFS&amp;REQUEST=GetCapabilities</dc:URI>
      <dc:URI protocol="WWW:DOWNLOAD-1.0-http--download" name="PARCELLE" description="Parcelles 1 - WWW">https://georchestra.dev.craig.fr/geoserver/psc/ows?SERVICE=WFS&amp;REQUEST=GetFeature&amp;typename=PARCELLE&amp;outputformat=shape-zip</dc:URI>
      <dc:URI protocol="OGC:3DTILES" name="Mesh Aurillac">https://3d.craig.fr/datasets/Aurillac/bati_avec_tecture/tileset.json</dc:URI>
      <dc:URI protocol="OGC:3DTILES" name="Bati Domérat">https://3d.craig.fr/datasets/Domerat_bati3d/3dtiles/tileset.json</dc:URI>
      <dc:URI protocol="OGC:COG" name="01 + 38 2018 à 25cm" description="ortho 2018 ain/isère (25cm)">http://cogeo.dev.craig.fr/opendata/ortho/2018_25cm_ain%2Bisere.tif</dc:URI>
      <dc:URI protocol="OGC:COG" name="Vichy 3cm" description="COG de 2021">https://cogeo.craig.fr/opendata/ortho/orthocraig3_vichy_2021.cog.tif</dc:URI>
    </csw:Record>
  </csw:SearchResults>

(yes, support for loading OGC:COG from the CSW results is also a target)

@tdipisa
Copy link
Member

tdipisa commented Jun 17, 2025

@landryb thank you for your contribution. I'm sorry, I see this PR is still in draft mode. Are you still working on this or can we mark it as ready for review?

@landryb
Copy link
Contributor Author

landryb commented Jun 17, 2025

@landryb thank you for your contribution. I'm sorry, I see this PR is still in draft mode. Are you still working on this or can we mark it as ready for review?

given the lack of feedback from developers at the time, i didn't dug further, and as i said in the first comment it was far from working.

But there's definitely an UX issue to fix in the end.... i'll have to recheck but the last changes made to handling of dc:URI didnt take into account the way the sample dataset i posted was handled:

  • if several 3dtiles links are set, allow the end-user to select from the available ones (as iirc is possible for the case of several WMS layers links)
  • dont assume url ending by .json is of type 3dtiles, also potentially check the protocol attribute (as its a standard way to specify the type within geonetwork)

@tdipisa tdipisa linked an issue Nov 4, 2025 that may be closed by this pull request
1 task
@tdipisa tdipisa added this to the 2026.01.00 milestone Nov 4, 2025
@tdipisa tdipisa requested a review from stefanocudini November 4, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve 3dtiles loading from CSW search

3 participants