fix: support external secrets for GeoServer credentials #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomorder
reviewed
Nov 24, 2025
| @@ -0,0 +1,35 @@ | |||
| {{- define "geoserver.context.xml" -}} | |||
Member
There was a problem hiding this comment.
can you please update the pool definition to match this one:
https://github.com/geosolutions-it/DevOps/wiki/JNDI-Resource-definition ?
randomorder
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using existing Kubernetes Secrets (external secrets) to provide GeoServer credentials
Introduced Changes
Chart.yaml: Bumped GeoServer chart version to 0.3.0values.yaml: Added configuration options to enable the use of external secrets. When external secrets are enabled, the corresponding value becomes the key used to reference the secretsecrets.yaml: Updated to conditionally skip creating GeoServer secrets when external secrets are enabledstatefulset.yaml: Updated to reference external secrets when they are configuredcontext.xml.tpl: Added a newcontext.xml.tpltemplate to replace the previous direct file reference incontext.xml, improving templating and customization supportREADME.md: Added documentation section on using external Kubernetes secrets