ImageIO-Ext update for JAI to ImageN Rename of classes and constants #334
Conversation
jodygarnett
changed the title
aaime
left a comment
aaime
left a comment
There was a problem hiding this comment.
Overall this looks pretty good, there are a few notes below.
Also done a "git grep jai", the bulk of the JAI references would go away if ParameterBlockJAI was to be renamed into ParameterBlockImagen, but there are a few other cases too (e.g., the licenses refer to JAI).
| * By default, ImageN uses hardware accelerated methods when available. For example, it make use of | ||
| * MMX instructions on Intel processors. Unluckily, some native method crash the Java Virtual | ||
| * Machine under some circumstances. For example on JAI 1.1.2, the {@code "Affine"} operation on | ||
| * Machine under some circumstances. For example on ImageN 1.1.2, the {@code "Affine"} operation on |
There was a problem hiding this comment.
When JAI was used with a version number, the migration does not look great. I'm guessing these need to be taken care of manually.
Just noting this one, there are other cases like this one in this diff.
There was a problem hiding this comment.
Oh interesting case, I will add that to script.
There was a problem hiding this comment.
Action:
- Replaced with
ImageN 1.1.2withImageNto cover this case - Replaced:
@since ImageN 1.1.2with@singe ImageN 0.4.0as the other example
| public synchronized static void setNativeAccelerationAllowed(final String operation, | ||
| final boolean allowed, | ||
| final JAI jai) | ||
| final ImageN jai) |
There was a problem hiding this comment.
Variable "jai" should probably be "imagen". There are other cases of this around.
There was a problem hiding this comment.
Thinking, I expect those may need to be cleaned up manually? Or towards the end of the script with a regex (thus far I have held off on regex).
There was a problem hiding this comment.
Action: I have updated script to replace these, with pretty good success so far.
Key goal for ImageN 0.9.0-SNAPSHOT development:
Concurrent merge of jai-rename branches:
Reviewers: Note complete ImageN integration test, or check out everything and build locally.